Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why log4rs don't support time-based rotate? #309

Closed
yunbo-xufeng opened this issue Apr 18, 2023 · 4 comments
Closed

Why log4rs don't support time-based rotate? #309

yunbo-xufeng opened this issue Apr 18, 2023 · 4 comments

Comments

@yunbo-xufeng
Copy link

I know currently log4rs only support size-triggered log rotate, and I also see several pull request have ever been sent to try to support time-based rotate, but clearly there is still no progress.
Time-based log rotate is very basic functionality, we really hope log4rs can support this feature.

@Dirreke
Copy link
Contributor

Dirreke commented Aug 15, 2023

I add it last year in #296. Maybe you can use log4rs = { git = "https://github.com/Dirreke/log4rs.git", branch = "time-triger"} for now.

@kwinz
Copy link

kwinz commented Oct 31, 2023

Thanks for you work @Dirreke! Any idea why is this not merged yet? I see loads of uncontroversial pull requests with thumbs up like yours and the documentation one #308 that haven't been merged for 6+ months.

@Dirreke
Copy link
Contributor

Dirreke commented Oct 31, 2023

I have no idea either.

@bconn98
Copy link
Collaborator

bconn98 commented Feb 10, 2024

#296 has been merged and released in v1.3.0!

@bconn98 bconn98 closed this as completed Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants