Variable erroneously tagged as ImplicitGlobalVariable

[pigulla]

This is probably a regression bug for the fix introduced in #21

Test script:

var escope = require("escope"),
    esprima = require("esprima");

var src = require("fs").readFileSync("source.js");

var ast = esprima.parse(src),
    scopes = escope.analyze(ast).scopes;

console.dir(scopes[0].variables[0].defs.map(function (def) {
    return def.type
}));

Input source:

var a; a = 42;

Output with escope 0.14.0:
[ 'Variable' ]

Output with escope 0.15.0 and 0.16.0:
[ 'Variable', 'ImplicitGlobalVariable' ]

[Constellation]

Nice catch! I'll fix it.

[Constellation]

ImplicitGlobalVariable is something different with normal Variables.

For example,

function inner() {
    eval(str);
    x = 20;
}

When this script is analyzed, x should be ImplicitGlobalVariable or not?

Treating ImplicitVariable as normal variables may break consistency.
I think adding new field globalScope.implicitVariables, adding implicit variables to it and removing implicit variables from normal variable map is better.

[Constellation]

I've added globalScope.implicit field and remove ImplicitGlobals from scope.variables.