Windows - esy-build: Failure building @esy-ocaml/reason

[bryphe]

After #242, this is the next issue blocking esy-reason-project from building on Windows - a build failure when building @esy-ocaml/reason:

917, characters 31-47:
         Warning 3: deprecated: String.lowercase
         Use String.lowercase_ascii instead.
               menhir src/reason-parser/reason_parser.{cmly,ml,mli} (exit 2)
         (cd _build/default/src/reason-parser &&
     C:\Users\bryph\.esy\3_\i\opam__slash__menhir-20171013.0.0-09217330\bin\menhir.exe
     --strict --unused-tokens --fixed-exception --table --cmly
     reason_parser.mly)
         Warning: you are using the standard library and/or the %inline
     keyword. We
         recommend switching on --infer in order to avoid obscure type error
     messages.
         Fatal error: exception Failure("output_value: not a binary
     channel")
               ocamlc
     src/reason-parser/.reason.objs/reason_oprint.{cmi,cmo,cmt}
         File "src/reason-parser/reason_oprint.ml", line 201, characters

Log here:
esy_ocaml__slash__reason-3.3.0-cfd98b7f.log

Minimal repro:
https://github.com/bryphe/esy-295-reason-repro

[bryphe]

Saw some issue with the same error here:
https://caml.inria.fr/mantis/view.php?id=5639

[bryphe]

It looks like this patch from the forked repo isn't being applied:
https://github.com/fdopen/opam-repository-mingw/blob/master/packages/menhir/menhir.20180703/files/menhir-20180703.patch

I believe that the error is caused by the open_out as opposed to open_out_bin in src/cmly_write.ml, like the above issue mentions. I confirmed that the patch is NOT applied to the menhir bits in my b folder.

[bryphe]

Fixed with the following:

• Windows: Port winfix for menhir@20171013 esy-ocaml/esy-opam-override#10
• Windows: Add menhir 20170712 override w/ winfix patch esy-ocaml/esy-opam-override#4