Color temperature is not proper

[daudarfin]

Describe the bug
Color temperature is not proper when I capture using the github application on non-supported devices. I don't see this issue with the Play store application.

Play store version works perfectly fine without any issues on non-supported devices.

To Reproduce
Steps to reproduce the behavior:

1. Capture an image in Photo mode
2. See the color temperature

Expected behavior
Color temperature should be similar what we see in the camera preview

Screenshots

I could reproduce this issue on multiple android devices (including Google Pixel phones). Please note, my devices are not part of the supported list.

[eszdman]

Does this problem persist with the latest source version? Where you can choose a color correction method

[daudarfin]

I am using the latest source version (checked-out yesterday) and I don't see such method for color correction.

There is a color method (not correction) which I already tried but it doesn't make any differences.

Color method:

1. Auto
2. Characteristics
3. Capture

Issue persists with all of the above methods.

Could you please let me know what is missing here when compared with Play store? Any changes (to fix this issue) required in source code would also help.

[eszdman]

Most likely this is due to the current session, I am using raw and jpeg stream at the same time
Some devices begin to behave differently when used this way at the moment I see the only solution is to enable dual session in device config file or upload config to repository

[daudarfin]

Dual session will fix this issue?

Could you please let me know how to enable this session in the source code? Is it JPEG + RAW option available inside Settings?

Is there any plan to fix this issue where device begin to behave differently?

[eszdman]

Could you please let me know how to enable this session in the source code?

PhotonCamera/app/src/main/java/com/particlesdevs/photoncamera/pro/Specific.java

Line 67 in e8f7550

File deviceSpecific = new File(sPHOTON_TUNING_DIR, "DeviceSpecific.txt");

Create DeviceSpecific.txt in DCIM/PhotonCamera/Tuning and write this line
isDualSessionSupported=true

[daudarfin]

Create DeviceSpecific.txt in DCIM/PhotonCamera/Tuning and write this line isDualSessionSupported=true

This doesn't help. Issue still persists even with dual session flag enabled.

After enabling, there is a crash observed while taking a picture.

java.lang.IllegalArgumentException: CaptureRequest contains unconfigured Input/Output Surface!

Even after fixing this crash, the color temperature is still improper.

[eszdman]

Fixed crash in latest versions

[daudarfin]

Thanks. The crash is fixed in the latest version.

But the color temperature issue still persists. The dual session support also didn't work. Could you please help me fixing this issue?