New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nit: change eslint file type #204

Merged

nebrelbug merged 1 commit into eta-dev:master from gurgunday:eslint-type-fix

Jan 1, 2023

Contributor

gurgunday commented Dec 23, 2022

.eslintrc.cjs was causing the following eslint error:

Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser. The extension for the file (.cjs) is non-standard. You should add "parserOptions.extraFileExtensions" to your config.

Since Eta doesn't use CJS internally, instead of doing that, I simply changed the config type to .json, which I prefer for configs like this one.


          change eslint file type

49d0d15

nebrelbug approved these changes

View reviewed changes

Collaborator

nebrelbug commented Jan 1, 2023

@gurgunday this looks good -- I'll merge now.

nebrelbug merged commit 8c82f3c into eta-dev:master

gurgunday deleted the eslint-type-fix branch

January 6, 2023 16:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment