Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/update cards after feedbacks #136

Merged
merged 11 commits into from Jul 13, 2022
Merged

Feat/update cards after feedbacks #136

merged 11 commits into from Jul 13, 2022

Conversation

nicolaskempf57
Copy link
Contributor

@nicolaskempf57 nicolaskempf57 commented Jul 11, 2022 •
edited

I updated search results based on mattermost feedbacks :

  • text changes for tags on organization card
  • 2 lines of reuses on dataset and organization pages
  • new dataset card on reuses pages
  • Add admin link to "participez"

Close datagouv/data.gouv.fr#886

@nicolaskempf57 nicolaskempf57 changed the title Feat/update cards after returns Feat/update cards after feedbacks Jul 11, 2022
maudetes
maudetes reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes!

Could we also change the organization link behavior on dataset cards? 🙏
The link is active on the entire line and not just on the text -> leading to mis-clic on my side.
image

CHANGELOG.md Outdated Show resolved Hide resolved
udata_front/views/dataset.py Outdated Show resolved Hide resolved
@nicolaskempf57
Copy link
Contributor Author

Could we also change the organization link behavior on dataset cards? 🙏 The link is active on the entire line and not just on the text -> leading to mis-clic on my side.

Done 👍🏻

maudetes
maudetes approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@nicolaskempf57 nicolaskempf57 merged commit aafcc28 into datagouv:master Jul 13, 2022
@nicolaskempf57 nicolaskempf57 deleted the feat/update-cards-after-returns branch July 13, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modifs des cartes suite aux retours
2 participants
@nicolaskempf57 @maudetes