Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move theme to gouvfr #244

Merged
merged 11 commits into from May 11, 2023
Merged

Move theme to gouvfr #244

merged 11 commits into from May 11, 2023

Conversation

nicolaskempf57
Copy link
Contributor

@nicolaskempf57 nicolaskempf57 commented Apr 25, 2023 •
edited

This PR moves the theme folder from udata-front root to gouvfr theme folder.

It also adds some glob to ease the use of udata-front with another theme.

Close datagouv/data.gouv.fr#565

@nicolaskempf57 nicolaskempf57 marked this pull request as ready for review April 27, 2023 12:01
maudetes
maudetes reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work smoothly, I'm impressed! 👏

I wonder if we should rename the second theme directory in udata_front/theme/${theme}/theme/... for clarity?

Don't forget the changelog, it might interest udata-front users ;)

@nicolaskempf57
Copy link
Contributor Author

I wonder if we should rename the second theme directory in udata_front/theme/${theme}/theme/... for clarity?

I agree, I think we can rename it to assets. What do you think ?

maudetes
maudetes approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment, seems to work nicely :)

crowdin.yml Show resolved Hide resolved
@nicolaskempf57 nicolaskempf57 merged commit 89eef51 into datagouv:master May 11, 2023
1 of 3 checks passed
@nicolaskempf57 nicolaskempf57 deleted the feat/move-theme-to-gouvfr branch May 11, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Déplacer tout le code du thème gouvfr dans udata_front/theme/gouvfr
2 participants
@nicolaskempf57 @maudetes