Fix tooltip accessibility #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maudetes
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Seems to work nicely :)
For later, do you think that we still need to use the hack we introduced over there on z-index results ?
udata_front/theme/gouvfr/assets/js/components/utils/Toggletip/Toggletip.mdx
Outdated
Show resolved
Hide resolved
…Toggletip.mdx Co-authored-by: maudetes <maudet.estelle@gmail.com>
Co-authored-by: maudetes <maudet.estelle@gmail.com>
The hack is still necessary. It's due to the background click so to remove it we must remove the click on the card background and use a simpler flow with only click on links or buttons, like the DSFR card below with multiple interactive elements :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the accessibility of our tooltip implementation, adds a new toggletip component and uses the toggletip in place of existing tooltips.
Close datagouv/data.gouv.fr#924