Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discoverability indicator form #304

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Add discoverability indicator form #304

merged 3 commits into from
Oct 11, 2023

Conversation

nicolaskempf57
Copy link
Contributor

@nicolaskempf57
Copy link
Contributor Author

Do we also remove the header button ?

maudetes
maudetes approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work nicely! 👏

Forwarding the question to @agarrone for the current header button

udata_front/theme/gouvfr/assets/js/components/vanilla/dialog.js Outdated Show resolved Hide resolved
@nicolaskempf57 nicolaskempf57 merged commit 6c68dd0 into datagouv:master Oct 11, 2023
7 checks passed
@nicolaskempf57 nicolaskempf57 deleted the feat/add-discoverability-indicator branch October 11, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mesurer l'indicateur de découvrabilité de la plateforme data.gouv.fr
2 participants
@nicolaskempf57 @maudetes