Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New footer with newsletter #311

Merged
merged 8 commits into from Nov 21, 2023
Merged

New footer with newsletter #311

merged 8 commits into from Nov 21, 2023

Conversation

nicolaskempf57
Copy link
Contributor

maudetes
maudetes approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor wording question in English

udata_front/theme/gouvfr/templates/newsletter.html Outdated Show resolved Hide resolved
@nicolaskempf57
Copy link
Contributor Author

nicolaskempf57 commented Nov 13, 2023 •
edited

Note : I forgot to add the icon in the new newsletter component

Edit : Done

@maudetes maudetes merged commit f57fb5d into datagouv:master Nov 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarrone agarrone agarrone left review comments

@maudetes maudetes maudetes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mise à jour du footer et mise en place de bandeau infolettre
3 participants
@nicolaskempf57 @maudetes @agarrone