Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add md editor #351

Merged
merged 41 commits into from Mar 28, 2024
Merged

Feat/add md editor #351

merged 41 commits into from Mar 28, 2024

Conversation

nicolaskempf57
Copy link
Contributor

@nicolaskempf57 nicolaskempf57 commented Feb 6, 2024 •
edited by maudetes

@nicolaskempf57
feat: ✨ add markdown editor component
dec7a10
@nicolaskempf57
feat(dataset): 🚧 add markdown editor wip
d895e4f
@nicolaskempf57
feat(dataset): 🚧 allow dsfr table in milkdown
29b19f9
@nicolaskempf57
chore: 🔧 update node version
a41c7f7
@nicolaskempf57
feat(dataset): 🚧 md editor
43537bc
@nicolaskempf57
chore(dataset): 🚧 markdown editor
391c964
@nicolaskempf57
feat(markdown-editor): ✨ handle table in markdown editor
bd1b83f
@nicolaskempf57
Merge branch 'master' into feat/add-md-editor
66a42f1
@nicolaskempf57
fix: 🐛 typo
ef4a760
@nicolaskempf57
fix: 🐛 fix storybook
109d648
@nicolaskempf57
chore: 🔥 remove vscode file
96a189c
@nicolaskempf57
feat: ✨ add edit tooltip
11c0557
@nicolaskempf57
feat(markdown-editor): ✨ add edit link and preview link
b2c96fb
@nicolaskempf57
feat(markdown-editor): ✨ handle link edit
b6ad244
@nicolaskempf57
feat(markdown-editor): ✨ add image modal
2faf274
@nicolaskempf57
feat(dataset): ✨ handle updates and add tests
1b027a1
@nicolaskempf57
refactor(markdown-editor): ♻️ use correct option ctx instead of dom m…
8406a19 
…anipulation
@nicolaskempf57
feat(markdown-editor): 💄 add top margin
60c2da1
@nicolaskempf57
fix(dataset): 🐛 fix error with reallllly long words
e44a70e
@nicolaskempf57 nicolaskempf57 marked this pull request as ready for review February 12, 2024 15:57
ThibaudDauce
ThibaudDauce reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@ThibaudDauce ThibaudDauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Doesn't seem easy to integrate with these libs.

...ront/theme/gouvfr/assets/js/components/MarkdownEditor/Milkdown/TableTooltip/TableTooltip.vue Outdated Show resolved Hide resolved
udata_front/theme/gouvfr/assets/js/components/MarkdownEditor/ImageModal/ImageModal.vue Outdated Show resolved Hide resolved
udata_front/theme/gouvfr/assets/js/components/MarkdownEditor/InternalEditor.vue Outdated Show resolved Hide resolved
@nicolaskempf57
feat(markdown-editor): ♿ add titles to table butttons
234bb33
@nicolaskempf57
feat(markdown-editor): ✨ improve usability of buttons for titles
e77b408
@nicolaskempf57
feat(markdown-editor): ♿ add required explanation to image modale
08db394
@nicolaskempf57
refactor(markdown-editor): ♻️ refac function
fe7b689
@nicolaskempf57
chore(storybook): 🚚 move uploadModal to internals
5aac0ab
@nicolaskempf57
chore(storybook): 🚚 move discussion internals
8634cd9
@nicolaskempf57
fix(markdown-editor): 🏷️ fix InputGroup type type
9457470
@nicolaskempf57
docs(markdown-editor): ✅ test and document image modal
a52f851
@nicolaskempf57
chore: 🏷️ move to TS
5f26003
@nicolaskempf57
docs(storybook): 📝 Update introduction
1bd41da
@nicolaskempf57
test(markdown-editor): ✅ add interaction test to ImageModalButton
aa96d4b
@nicolaskempf57
docs(markdown-editor): 📝 Document ImageModalButton
3e490ab
@nicolaskempf57
docs(markdown-editor): 📝 add doc
9791ef5
@nicolaskempf57
docs(markdown-editor): 📝 add markdown editor documentation
59eaa70
maudetes
maudetes approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow! Indeed, it's quite a lot of work to integrate with the libs.
I haven't dived in all the files, but it seems to work nicely already, thank you! 🚀

As a suggestion, it may be nice, later on, to add a raw mode to edit markdown without the rendering (for geeky users).

.circleci/config.yml Show resolved Hide resolved
udata_front/theme/gouvfr/assets/js/components/MarkdownEditor/ImageModal/ImageModal.vue Outdated Show resolved Hide resolved
...ront/theme/gouvfr/assets/js/components/MarkdownEditor/Milkdown/LinkPreview/useLinkPreview.ts Show resolved Hide resolved
@nicolaskempf57 @maudetes
Update udata_front/theme/gouvfr/assets/js/components/MarkdownEditor/I…
991a218 
…mageModal/ImageModal.vue

Co-authored-by: maudetes <maudet.estelle@gmail.com>
@nicolaskempf57
Copy link
Contributor Author

As a suggestion, it may be nice, later on, to add a raw mode to edit markdown without the rendering (for geeky users).

I agree, we could add a "plain text" option with a simple textarea

@nicolaskempf57 nicolaskempf57 merged commit 1cc30c4 into datagouv:master Mar 28, 2024
7 checks passed
@nicolaskempf57 nicolaskempf57 deleted the feat/add-md-editor branch March 28, 2024 08:24
Jorek57 pushed a commit to Jorek57/udata-front that referenced this pull request Apr 2, 2024
@nicolaskempf57 @maudetes @Jorek57
Feat/add md editor (datagouv#351)
3f08f98 
* feat: ✨ add markdown editor component

* feat(markdown-editor): ✨ handle table in markdown editor

* feat: ✨ add edit tooltip

* feat(markdown-editor): ✨ handle link edit

* feat(markdown-editor): ✨ add image modal

---------

Co-authored-by: maudetes <maudet.estelle@gmail.com>
@abulte abulte mentioned this pull request Apr 3, 2024
Open
@streino
Copy link

streino commented Apr 4, 2024

@nicolaskempf57 ça serait possible de l'avoir dans @etalab/data.gouv.fr-components ?

@nicolaskempf57
Copy link
Contributor Author

@nicolaskempf57 ça serait possible de l'avoir dans @etalab/data.gouv.fr-components ?

@streino Complètement ! Il faut qu'on termine datagouv/data.gouv.fr#1265 avant pour avoir des releases propres du package NPM avec changelog notamment et qu'on refasse un viewer markdown (fait initialement dans #337) avec le même parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaudDauce ThibaudDauce ThibaudDauce left review comments

@maudetes maudetes maudetes approved these changes

@Jorek57 Jorek57 Jorek57 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parcours de publication : Nouvel éditeur Markdown
5 participants
@nicolaskempf57 @streino @ThibaudDauce @maudetes @Jorek57