Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin udata version in setup.py #384

Merged
merged 3 commits into from Apr 5, 2024

Conversation

maudetes
Copy link
Contributor

@maudetes maudetes commented Mar 29, 2024

Fix datagouv/data.gouv.fr#1328

In etalab/udata-gouvfr#626, the install_requires of setup.py used a pinned version of udata if defined.
It prevents installing udata-front with any other working udata versions.

It was meant to be used in the release instead of the udata.git.
However, the version used to build the udata-front release shouldn't be added as a fixed dep in install_requires udata-front, but should only be used to install deps.

The latest release is already used in CI by replacing the dep to udata.git git by udata.
We then apply

pip-compile requirements/udata.in --output-file=requirements/udata.pip
...
pip install -r requirements/udata.pip

We're correctly using the latest udata release at this point (#363).

Historically, udata wasn't pinned to a specific version (v3.1.3, v2.0.0 (see info > requires_dist)).

Thus, let's remove the udata pinned version in the install_requires in setup.py

@maudetes maudetes merged commit eb55b32 into datagouv:master Apr 5, 2024
6 of 7 checks passed
@maudetes maudetes deleted the chore/unpin-udata-version branch April 5, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enlever la contrainte de version de udata dans les requirements udata-front
2 participants