Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wrap thread header above md screens #64

Conversation

nicolaskempf57
Copy link
Contributor

Header and copy buttons aren't wrapped to a new line on lg screen and above. They are wrapped for md screens and below. Here are some screenshots to see the wrap / nowrap for :

  1. desktop
  2. lg screen just above md
  3. md screen

Capture d’écran 2022-01-12 à 10 00 34

Capture d’écran 2022-01-12 à 10 01 11

Capture d’écran 2022-01-12 à 10 01 21

We can add more changes if we want to :

  • The current text-wrap is the browser default, we can update it if we want to keep the link on a single line for example.
  • There is no col with width in this PR (like col-8), we can use this solution if we want more control about the ratio between title and link.

Close datagouv/data.gouv.fr#670

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're all good :)

@nicolaskempf57 nicolaskempf57 merged commit f6f346f into datagouv:master Jan 26, 2022
@nicolaskempf57 nicolaskempf57 deleted the fix/fix-discussion-copy-link-on-new-line branch January 26, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants