-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix structured data (microdata) properties, refs #354 #372
Conversation
@@ -52,11 +52,13 @@ | |||
{% endblock %} | |||
|
|||
{% block content %} | |||
<div itemscope="itemscope" itemtype="http://schema.org/Dataset" itemid="{{dataset.id}}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why an extra div ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have all sections in it for complex relations (isPartOf, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. It does not break the style ?
I think |
I reverted the removal of |
@@ -1,6 +1,6 @@ | |||
{% set resource_format = resource.format|trim|lower or 'data' %} | |||
<div id="resource-{{resource.id}}" class="list-group-item" | |||
itemscope="itemscope" itemtype="http://schema.org/DataDownload" | |||
itemscope itemtype="http://schema.org/DataDownload" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs itemprop="distribution"
to be properly attached to the dataset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
r+wc |
Fix structured data (microdata) properties, refs #354
No description provided.