Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx.Commit() - function not implemented #684

Closed
gandarez opened this issue Jan 30, 2024 · 6 comments
Closed

tx.Commit() - function not implemented #684

gandarez opened this issue Jan 30, 2024 · 6 comments

Comments

@gandarez
Copy link

The tx.Commit() fails with function not implemented for OpenBSD. Is it expected?

  • OS: OpenBSD
  • Platform: AMD64
@alanhamlett
Copy link

Could it be this code?

func fdatasync(db *DB) error {

Which either calls File.Sync or unix.Msync.

@gandarez
Copy link
Author

gandarez commented Feb 3, 2024

Could it be this code?

func fdatasync(db *DB) error {

Which either calls File.Sync or unix.Msync.

It's missing go build tag in the top to only build for OpenBSD 🤔

@ahrtr
Copy link
Member

ahrtr commented Feb 3, 2024

It's missing go build tag in the top to only build for OpenBSD

It isn't necessary, because the filename bolt_openbsd.go already has suffix "_openbsd.go".

Unfortunately, I don't have a OpenBSD VM right now, so can't debug the issue. Could you try the main branch, which has more info in the error message?

@gandarez
Copy link
Author

gandarez commented Feb 3, 2024

Didn't know this approach of suffixing the file. I believe we can try with master branch. I'll let you know soon after we run the tests.

@gandarez
Copy link
Author

gandarez commented Feb 6, 2024

Updating bbolt to v1.3.8 fixed it.

@ahrtr
Copy link
Member

ahrtr commented Feb 6, 2024

It should have been fixed in #406 in 1.3.8.

@ahrtr ahrtr closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants