Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install etcd/tools/benchmark via go get #11532

Closed
Cjen1 opened this issue Jan 16, 2020 · 10 comments
Closed

Can't install etcd/tools/benchmark via go get #11532

Cjen1 opened this issue Jan 16, 2020 · 10 comments

Comments

@Cjen1
Copy link
Contributor

Cjen1 commented Jan 16, 2020

Using go get go.etcd.io/etcd/tools/benchmark results in:

go/src/go.etcd.io/etcd/vendor/google.golang.org/grpc/balancer_conn_wrappers.go:28:2: use of internal package google.golang.org/grpc/internal/buffer not allowed 
go/src/go.etcd.io/etcd/vendor/google.golang.org/grpc/clientconn.go:49:2: use of internal package google.golang.org/grpc/internal/resolver/dns not allowed
go/src/go.etcd.io/etcd/vendor/google.golang.org/grpc/clientconn.go:50:2: use of internal package google.golang.org/grpc/internal/resolver/passthrough not allowed

This has worked previously and is running on go version go1.11.5 linux/amd64

@Cjen1
Copy link
Contributor Author

Cjen1 commented Jan 16, 2020

This command does work however on go version go1.10.4 linux/amd64

@spzala
Copy link
Member

spzala commented Jan 17, 2020

@Cjen1 can you also please try the latest supported go 1.13 and see how that goes? Thanks!

@Cjen1
Copy link
Contributor Author

Cjen1 commented Jan 17, 2020

Hi trying on go version go1.13.6 linux/amd64 fails with the same error. I've gotten around this by cloning the repo locally and then using go build && go install and that has appeared to work, it is just the go get version which fails.

@spzala
Copy link
Member

spzala commented Jan 18, 2020

@Cjen1 thanks for verifying. I think the error is due to the vendor directory is missing the referenced internal packages. I am digging into it more and will work on fix. Thanks!

@spzala
Copy link
Member

spzala commented Jan 18, 2020

/cc @YoyinZyc

@spzala
Copy link
Member

spzala commented Jan 29, 2020

@Cjen1 This is fixed under #11557 I am closing the issue after successfully running the go get. Please reopen if needed. Thanks!

@spzala spzala closed this as completed Jan 29, 2020
@brunobcfum
Copy link

go get go.etcd.io/etcd/tools/benchmark

go.etcd.io/etcd/clientv3/balancer/picker

../go/src/go.etcd.io/etcd/clientv3/balancer/picker/err.go:25:9: cannot use &errPicker literal (type *errPicker) as type Picker in return argument:
*errPicker does not implement Picker (wrong type for Pick method)
have Pick(context.Context, balancer.PickInfo) (balancer.SubConn, func(balancer.DoneInfo), error)
want Pick(balancer.PickInfo) (balancer.PickResult, error)
../go/src/go.etcd.io/etcd/clientv3/balancer/picker/roundrobin_balanced.go:33:9: cannot use &rrBalanced literal (type *rrBalanced) as type Picker in return argument:
*rrBalanced does not implement Picker (wrong type for Pick method)
have Pick(context.Context, balancer.PickInfo) (balancer.SubConn, func(balancer.DoneInfo), error)
want Pick(balancer.PickInfo) (balancer.PickResult, error)

I am getting this error on:
go version go1.15.2 linux/amd64

@christiansicari
Copy link

@brunobcfum did you solved? I am stuck with same issue

@brunobcfum
Copy link

@brunobcfum did you solved? I am stuck with same issue

Try downloading the whole etcd repository and in the main folder run:
go build -v ./tools/benchmark

The benchmark executable will be compiled in the main folder.

@christiansicari
Copy link

christiansicari commented Jan 5, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants