New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve contributor experience with CI #13896
Comments
|
|
@ptabor Thanks! For me |
@willbeason the PR #13956 should fix the issue you are facing |
Not all issues listed were addressed |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
With introduction of |
Hey @serathius @jmhbnz Can you please assign me to this? I am keen to work on it. With the example of Are we proposing to split this individual target to a separate file called |
Sounds good @sharathsivakumar, thanks for looking into this! |
@serathius and @jmhbnz I have been away due to personal issues and could not complete this. However I am back now and I will get this done soon. I am looking to turn in the first PR by early next week. Hope that's fine. |
Not a problem, great to hear you are still interested. Awaiting your PR. |
In CONTRIBUTING.md, list scripts in scripts/ that a first-time contributor would need (and what they're for). Or - have a short explanation at the top of each script which briefly says what it's for. (Doesn't have to be a full usage guide, just "Updates license information in modules and submodules. CI checks that running this causes no changes." would go a long way)For CI failures, suggest the appropriate script to fix the corresponding failure. For example, if the bom test fails, most likely the contributor just needs to run ./scripts/fix.shWith introduction of
make test-*
make verify-*
andmake fix-*
I would propose to split./scripts/test.sh
to separate targets and document them all in makefile. Having afix-*
target for eachverify-*
should address the issue.The text was updated successfully, but these errors were encountered: