Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move installation scripts out of release info #15185

Closed
serathius opened this issue Jan 26, 2023 · 4 comments
Closed

Move installation scripts out of release info #15185

serathius opened this issue Jan 26, 2023 · 4 comments

Comments

@serathius
Copy link
Member

What would you like to be added?

Installation script should be moved into either etcd.io or etcd repo. Options:

  • Update https://etcd.io/docs/v3.5/install/ and link to it from release
  • Add script to repo that can be executed directly from . Execution by calling
    wget https://raw.githubusercontent.com/etcd-io/etcd/v3.5.7/projects/scripts/install.sh
    chmod +x ./install.sh
    ./install.sh
    
    or more extreme
    bash < <(curl -s -S -L https://raw.githubusercontent.com/etcd-io/etcd/v3.5.7/projects/scripts/install.sh)
    

Prefer first option as second doesn't allow user good chance to read what script is doing.

Why is this needed?

From time to time we need to make a fix in release script and as it's separate for each release it's very toilsome. During release maintainer copies it from last release and needs to manually update version which is error prone as there are a lot of references to version. If change is script needs to be done it needs to be done by maintainers as release info is not stored in repository.

All those things result in install script being not very maintained and low quality.

@pchan
Copy link
Contributor

pchan commented Feb 9, 2023

Created a PR (#15267) that adds the installation script. Please review, I will update the website v3.6 docs ? post review.

@serathius
Copy link
Member Author

Would be good to check what other project do in this regard.

@pchan
Copy link
Contributor

pchan commented Feb 9, 2023

Would be good to check what other project do in this regard.

Analyzed 2 examples

  1. Build from source, as in, use "make" to build and then install ? (like (runc. Currently we install to a temp directory.
  2. Other option is to install with popular package managers (e.g. kubeadm binaries)

@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 21, 2023
@stale stale bot closed this as completed Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants