Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs probably use dev image not release image #8078

Closed
erikbgithub opened this issue Jun 11, 2017 · 2 comments
Closed

Docs probably use dev image not release image #8078

erikbgithub opened this issue Jun 11, 2017 · 2 comments

Comments

@erikbgithub
Copy link

For instance this page doesn't contain the etcd binary in their code examples. But if you install the release image instead of however you start the devel image you won't have an ENTRYPOINT, so you need to explicitely state the binary you want to use.

@gyuho
Copy link
Contributor

gyuho commented Jun 12, 2017

https://coreos.com/etcd/docs/latest/v2/docker_guide.html assumes that you are running v2.

Since v3, we use CMD https://github.com/coreos/etcd/blob/master/NEWS#L154.

We prefer to use release image for all docs. I think it's clear as long as we specify the image tag as here https://github.com/coreos/etcd/blob/master/Documentation/v2/docker_guide.md#etcd0.

Please let me know if you have any other questions.

@gyuho gyuho closed this as completed Jun 12, 2017
@erikbgithub
Copy link
Author

I see, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants