Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jitter in ProgressNotify #9246

Closed
cw9 opened this issue Jan 29, 2018 · 5 comments
Closed

Add jitter in ProgressNotify #9246

cw9 opened this issue Jan 29, 2018 · 5 comments

Comments

@cw9
Copy link

cw9 commented Jan 29, 2018

We use ProgressNotify in most of our etcd watchers and notice that the etcd servers have a spike of etcd_network_client_grpc_sent_bytes_total every exact 10 minutes. We think it's because we created a lot of watchers at the same time so every 10 minutes the servers need to send out progress update for every watcher. Is it true? If so, is it possible to add some jittering for the progress notify on the server side to avoid this kind of network spike?

I vaguely recall that the progress notification is supposed to be approximately every 10 minutes in the past, was it changed to exact every 10 minutes recently?

@xiang90
Copy link
Contributor

xiang90 commented Jan 29, 2018

@cw9

i agree we should add jitter to it as we add jitter to the internal lease revoke.

would you have time to try to add jitter. or @gyuho or I might give it a try soon.

@gyuho
Copy link
Contributor

gyuho commented Jan 29, 2018

Yeah jittering was added to lease revoke, not to watch progress notify.
Should be straightforward to do the same for watch.

@cw9
Copy link
Author

cw9 commented Jan 29, 2018

If it's straightforward to you guys, it's probably easier for you to make the change

@gyuho
Copy link
Contributor

gyuho commented Jan 29, 2018

@cw9 Sure, we will address this in next release cycle 3.4.

@gyuho gyuho added this to the v3.4.0 milestone Jan 29, 2018
@cw9
Copy link
Author

cw9 commented Jan 29, 2018

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants