Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chainconfig iface use array to represent feature enablement #138

Open
meowsbits opened this issue Feb 3, 2020 · 0 comments
Open

Comments

@meowsbits
Copy link
Member

ECIP1078 proposes to Disable EIP2200. Disabling features happens more rarely than enabling them, but this will not be the first case (nor likely the last).

The current interface here and in other clients treats Fork Features as one-time-on values, and disabling them requires adhoc one-time-off configuration and supportive business logic. This is pretty ugly.

Proposing here to use instead an idea of "Feature Enabled Ranges" which would be arrays of block numbers, rather than lone number values.

eg.

FeatureATransitions = [1420000] // Enable feature without (ever, yet) disabling
FeatureBTransitions = [1420000, 1950000] // Enable feature from blocks 1420000 through 1950000
FeatureCTransitions = [1420000, 1950000, 2120000] // Enable, disable, then reenable the feature.

All mod%1=1 index array values are enabling feature, all ==0 are disabling.

Rel #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant