Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un"hardcode" setting chain configuration #67

Open
meowsbits opened this issue Nov 23, 2019 · 1 comment
Open

un"hardcode" setting chain configuration #67

meowsbits opened this issue Nov 23, 2019 · 1 comment

Comments

@meowsbits
Copy link
Member

meowsbits commented Nov 23, 2019

this needs improving:

https://github.com/etclabscore/multi-geth/blob/master/cmd/utils/flags.go#L1567-L1623

having "hardcoded" switches for default chain configs everywhere is too complex and too redundant and leaves too many opportunities for errors and inconsistencies:

much of this is because of crufty, brittle code (inheriting code where these cases have been carelessly hardcoded with approaching infinite opinionation).

I'm not sure the best pattern for approach yet. Big global? Moar interfaces? Mmmm..

Rel #63

@meowsbits
Copy link
Member Author

Changes should (eventually):

  • Provide a LIST of available default chain configurations
  • Read default chain configurations from JSON files instead of having them hardcoded in Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant