Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not work on ReactNative version >= 0.39.0 #1

Closed
TSMMark opened this issue Dec 6, 2016 · 6 comments
Closed

Plugin does not work on ReactNative version >= 0.39.0 #1

TSMMark opened this issue Dec 6, 2016 · 6 comments

Comments

@TSMMark
Copy link

TSMMark commented Dec 6, 2016

Try it and see.

@eteeselink
Copy link
Owner

Hey! Thanks for your comment.

I don't currently use React Native for anything, so "try it and see" amounts to "set up and learn a whole React Native dev environment", which I don't have time for.

However, I'd be happy to accept a pull request that fixes this. Do you have any idea where it goes wrong? Do you know whether it worked on earlier versions of React Native?

@TSMMark
Copy link
Author

TSMMark commented Dec 12, 2016

Hi, yes, sorry I should have been more detailed. It worked in React Native 0.38.x. Unfortunately, I have no idea where it is going wrong, as I am not very familiar with babel plugin architecture in general, and even less so with this specific plugin.

What I can say for sure is that after upgrading from 0.38 to 0.39, our react component classes no longer had the static property displayName at run time.

@eteeselink
Copy link
Owner

Impressive. In all honesty I have no good idea where to look. The RN changelog doesn't say anything about a change in how the react component base classes work or something.

You could help by making an example app of the tiniest possible RN application which exhibits this problem. I'm curious whether the babel output contains the displayName property correct in that setup, and whether it changed between RN 0.38 and 0.39. If there's no change there, then I'd wager there's no real bug in this plugin per se but RN does something to overwrite or remove the displayName property at runtime.

If that's the case, maybe we can come up with a workaround.

@TSMMark
Copy link
Author

TSMMark commented Dec 13, 2016

I think making an example app of the tiniest possible RN application which exhibits this problem is a great idea, but unfortunately, I won't be able to get to this anytime soon.

@eteeselink
Copy link
Owner

Ok. I'll leave this issue open in case someone else gets in trouble because of this and has an idea. Thanks for reporting!

@eteeselink
Copy link
Owner

Closing this issue because of low activity. Feel free to reopen if you hit this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants