Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The syntax highlighter is a bit naive #421

Open
eteran opened this issue May 18, 2016 · 1 comment
Open

The syntax highlighter is a bit naive #421

eteran opened this issue May 18, 2016 · 1 comment

Comments

@eteran
Copy link
Owner

eteran commented May 18, 2016

The syntax highlighter works well, but is a little naive, for example when highlighting a symbol such as:

libasm-0.163.so!__x86.get_pc_thunk.bx

the 0.163 is highlighted as a numeric value and the bx is highlighted as a register. We should probably add a little bit of context awareness to the highlighter to make it get these little details correct.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@10110111
Copy link
Contributor

It's indeed naive and doesn't work well in some cases, but it's also quite slow. It seems it should be done in some other way than using regexp, although I don't know what ways would those be. Maybe the instructions themselves should be drawn more "manually", i.e. mnemonic with separate highlighting, then operands, where symbolic addresses are already known to be present or not, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants