Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Enter Lab" carousel button should go to lab page, not puzzle progression #30

Closed
Omei opened this issue May 12, 2020 · 3 comments
Closed

"Enter Lab" carousel button should go to lab page, not puzzle progression #30

Omei opened this issue May 12, 2020 · 3 comments
Labels
good first issue Good for newcomers type: bug Something isn't working

Comments

@Omei
Copy link

Omei commented May 12, 2020

  1. For any existing player who currently has lab access, entering the lab from the main page should not go to the puzzle progression. It should go to some page that makes it clear what labs, if any, are currently open.

2)It looks like that would be http://eternadev.org/labs?size=27&filters=active, in the current design, but the filter doesn't seem to be implemented.
@luxaritas luxaritas changed the title "Enter Lab" action should be different for current lab participants. "Enter Lab" carousel button should go to lab page, not puzzle progression May 12, 2020
@luxaritas
Copy link
Member

In this case it should actually be the specific lab in the given carousel slide, not the entire lab list

@luxaritas luxaritas added type: bug Something isn't working High Priority good first issue Good for newcomers labels May 14, 2020
@guyguy2001
Copy link
Contributor

I can't seem to reproduce this. Are you talking about this button? It takes me to the lab page.
image

@luxaritas
Copy link
Member

Yeah looks like this must've been resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Omei @guyguy2001 @luxaritas