Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALL links should use either <router-link> or <a> #33

Closed
luxaritas opened this issue May 12, 2020 · 0 comments
Closed

ALL links should use either <router-link> or <a> #33

luxaritas opened this issue May 12, 2020 · 0 comments
Assignees
Labels
type: bug Something isn't working

Comments

@luxaritas
Copy link
Member

This is a significant accessibility issue, and also prevents the link from being properly displayed by the browser when hovering over it. One big area this happens is in the nav, but this is true for everywhere on the page. As a rule, if the user clicks something and that causes the page to change, in the end it should always be rendered as an anchor tag (which router-link also does for us)

@akrolsmir akrolsmir self-assigned this May 12, 2020
@akrolsmir akrolsmir added the type: bug Something isn't working label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants