Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails version #25

Closed
webchi opened this issue Jun 14, 2017 · 4 comments
Closed

Rails version #25

webchi opened this issue Jun 14, 2017 · 4 comments

Comments

@webchi
Copy link

webchi commented Jun 14, 2017

Hi. README sad:

PropertyWebBuilder runs with Rails >= 5.0

But in the bundler:

Resolving dependencies...
Bundler could not find compatible versions for gem "rails":
  In Gemfile:
    rails (~> 5.1.1)

    pwb was resolved to 1.0.0, which depends on
      rails (>= 5.0.0.1, ~> 5.0.0)

What version is work?

@etewiah
Copy link
Owner

etewiah commented Jun 14, 2017

I use Rails 5.0.3 so I know that works. I haven't tested with other versions of Rails 5 but I don't know of any particular issues with other versions of Rails 5.
Are you having a problem with the version of rails that you are using?

@webchi
Copy link
Author

webchi commented Jun 18, 2017

Yes. Bundle could not solve dependencies with rails 5.1.1 It seems pwb frozen to 5.0 version
https://github.com/etewiah/property_web_builder/blob/master/pwb.gemspec#L20
s.add_dependency 'rails', '~> 5.0.0', '>= 5.0.0.1'
~> 5.0 makes it working just under 5.0 version but not 5.1

@etewiah
Copy link
Owner

etewiah commented Jun 18, 2017

Hi @webchi , you are right. I probably shouldn't have that restriction in the gemspec. I have loosened the restriction on the version of rails and pushed that update to the repository.

Let me know if that fixes it for you.

@etewiah
Copy link
Owner

etewiah commented Jun 27, 2017

I believe this issue is resolved so I'll go ahead and close it.

@etewiah etewiah closed this as completed Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants