Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holesky DNS Network for Peer Discovery #58

Closed
holgerd77 opened this issue Aug 24, 2023 · 7 comments
Closed

Holesky DNS Network for Peer Discovery #58

holgerd77 opened this issue Aug 24, 2023 · 7 comments

Comments

@holgerd77
Copy link

Hi there,
Holger from EthereumJS here, we have just integrated the Holesky testnet into our client codebase ethereumjs/ethereumjs-monorepo#2982 , excited for the launch ! 🎉

When looking over the configuration I wondered, will there be a DNS server/network for peer discovery as being setup for Sepolia or Goerli (with a URL like enrtree://AKA3AM6LPBYEUDMVNU3BSVQJ5AD45Y7YPOHJLEF6W26QOE4VTUDPE@all.sepolia.ethdisco.net)? And if so will it be active from the start on?

I think normally people from Go Ethereum run these servers, maybe tagging her @holiman therefore? 🤔

If there is/will be a DNS server available it would also be nice if the address can be added to the initial README description.

Ok, so far, have a great testnet start! 🙂 🙏

@parithosh
Copy link
Member

Hey! We're gonna look into this and try to get it done asap, unsure if it'll make it in time for all client releases though. It'll land up on the same domain, all.holesky.ethdisco.net.

@parithosh
Copy link
Member

Martin deployed the PR to add support for Holesky. You can check the data here: https://github.com/ethereum/discv4-dns-lists

dig all.holesky.ethdisco.net ANY responds with a enrtree-root now.

@holgerd77
Copy link
Author

Very cool and thanks a lot (also to Martin) 🙏, we will try out very soon and give a quick feedback here! 🙂

Might also be a good idea to re-post respectively point to here in R&D Discord #testnets or so channel for visibility.

@holgerd77
Copy link
Author

Ah, and this should likely also be added to the metadata section here?

@parithosh
Copy link
Member

created a PR to address the documentation: #86

@holgerd77
Copy link
Author

Ah sorry, never came back to this. Just a late confirm that this works fine, here is an extract from our devp2p logs on a Holesky run:

grafik

@parithosh
Copy link
Member

Thanks for the update! I'll close the issue and merge the respective PR then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants