Update cmake #14
Merged
Update cmake #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpintarelli
force-pushed
the
update-cmake
branch
from
d91c475
to
b7e134d
Compare
kabicm
reviewed
Feb 5, 2023
CMakeLists.txt
Outdated
| list(APPEND TILEDMM_EXTERNAL_LIBRARIES ROCBLAS::rocblas HIPLIBS::hiplibs) | ||
| list(APPEND TILEDMM_DEFINITIONS -D__HIP_PLATFORM_HCC__) # since we are not using the hcc compiler, we have to set up this explicitly | ||
| find_package(rocblas REQUIRED) | ||
| list(APPEND TILEDMM_EXTERNAL_LIBRARIES rocs::rocblas) |
There was a problem hiding this comment.
is rocs a typo for rocm or is it on purpose?
There was a problem hiding this comment.
Thanks, yes this is a typo.
simonpintarelli
force-pushed
the
update-cmake
branch
3 times, most recently
from
2c00c9d
to
b38200f
Compare
- if exists libs/cxxopts is used as submodule, otherwise use find_package - use rocm provided find rocblas - set TILEDDMM_GPU_BACKEND as option with a default value - always install, remove TILEDMM_WITH_INSTALL cmake option - use TARGET_NAME_IF_EXISTS in target_link_libraries - Tiled-MMConfig add targets for tiledmm::cuda|rocm - export compile_commands.json
simonpintarelli
force-pushed
the
update-cmake
branch
from
b38200f
to
3c4a91e
Compare
mtaillefumier
approved these changes
Feb 14, 2023
simonpintarelli
force-pushed
the
update-cmake
branch
from
5d17f8c
to
2c43a0f
Compare
|
feel free to merge it whenever you think it is ready. |
- remove `--recursive` from git clone (not required anymore, since cxxopts must be found as external dependency)
simonpintarelli
force-pushed
the
update-cmake
branch
from
2c43a0f
to
1b30619
Compare
Ok, let's wait until Marko approves it. |
|
Thanks Simon and Mathieu! Looks great to me! |
kabicm
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if exists libs/cxxopts is used as submodule, otherwise use find_packagegit cloneinstead ofgit cone --recursivefind_package(rocblas)