Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add simple docker action #54

Closed
wants to merge 3 commits into from
Closed

workflows: add simple docker action #54

wants to merge 3 commits into from

Conversation

RiRa12621
Copy link
Contributor

This fixes #53

@RiRa12621
Copy link
Contributor Author

This needs a little more work since for some reason the app exits 1 and not 0

@eth0izzle
Copy link
Owner

Thanks. I've just setup a Docker Hub account and integrated the build that way. Any changes to the repo will kick off a build there. Is there any reason for this now?

@RiRa12621
Copy link
Contributor Author

Yeha my idea was that an action would be triggered on every PR, so people could easily see if their changes breaks things
this action would build the image and run it to be sure the building works and running as well

@eth0izzle
Copy link
Owner

Ahh I'll see. Soo every PR regardless if I merge them in to main. Yeah that's pretty cool. I'll check this out.

@eth0izzle eth0izzle closed this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add Github action to test PRs
2 participants