Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package deprecated #91

Closed
ethanent opened this issue Feb 20, 2024 · 11 comments
Closed

Package deprecated #91

ethanent opened this issue Feb 20, 2024 · 11 comments

Comments

@ethanent
Copy link
Owner

Please reply if you have any questions about Phin's deprecation.

Some popular alternatives (no endorsement, I may not have used them) include:

Please migrate to another HTTP request solution at your earliest convenience.

@yetzt
Copy link

yetzt commented Feb 21, 2024

But why?

@ASaiAnudeep
Copy link

@ethanent could you help us understanding the reason behind deprecating this package. Let me know if we can maintain phin and centra under our org - https://github.com/pactumjs

@yetzt
Copy link

yetzt commented Mar 21, 2024

i made a fork, pulled in centra, fixed some bugs, added features, removed the tests for now because the testing library (whew) was unpublished too... ported the tests; it's pretty much a drop in replacement, i will use it in my own packages and implement updates and fixes as needed.

feel free to use it, send pull requests or give feedback.

@XuluWarrior
Copy link

@yetzt It would be good know what bugs were fixed and what features were added :)

@XuluWarrior
Copy link

Regarding the deprecation of this package, I note in the npm stats that it has 1 million weekly downloads.
It would be great if there was a (semi)official continuation of this project with a new maintainer
(@yetzt's efforts are already appreciated)

@yetzt
Copy link

yetzt commented Mar 24, 2024

It would be good know what bugs were fixed and what features were added :)

#88 (compressed streams throw exception), #78 (redirect limit) and #79 (centra query is not exposed)

i'm looking into the other issues as well.

@ethanent
Copy link
Owner Author

Hi all, version 4.0.0 of the library has been released which uses Axios under the hood and is not deprecated currently. Give it a try! Thanks for your comments.

@jdforsythe
Copy link
Contributor

Hi all, version 4.0.0 of the library has been released which uses Axios under the hood and is not deprecated currently. Give it a try! Thanks for your comments.

If axios was suggested as an alternative, but now this uses axios under the hood, what is this providing that axios doesn't?

@sleeyax
Copy link

sleeyax commented Mar 26, 2024

This situation is being handled poorly, OP. You're not answering any questions about the deprecation (like you said you would) and there are infinitely better options than just republishing axios... It's like no thought was put into this at all.

I recommend to unpublish v4 and transform this issue into a discussion so we, as a community, can figure out the future of this package. Together. Communication is key in open source.

@ethanent
Copy link
Owner Author

Hi! Let's move the discussion about v4 to #92. Thank you.

@ethanent
Copy link
Owner Author

Maintainers wanted: #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants