Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you do not have space in your inventory for an item, making space for it does not make it appear like it does in vanilla #289

Closed
MrDanOak opened this issue Dec 13, 2022 · 1 comment · Fixed by #303
Labels
Milestone

Comments

@MrDanOak
Copy link
Contributor

Scenario: you have a 1x1 item in every top row of your inventory, you also have a twin blades on your account (2x5). You move two of the 1x1 items creating a free 2x5 space for your TB to fall into.

Expected: TB appears as soon as the second 1x1 item is moved making space for it.
Actual: Relog required.

I would expect this would involve tracking items that could not fit into your inventory on login & checking if there is now space for them when an item in your inventory is moved. The definition of "moved" is not having any items attached to your cursor so you are not forced to drop something.

@ethanmoffat
Copy link
Owner

ethanmoffat commented Dec 13, 2022

I think this could potentially be pretty easy. I didn't realize vanilla client would appear items that didn't fit if you made space for them.

My idea for resolving this was to add a scrollbar, basically double the size of the inventory. I haven't thought too much about item scrolling. Even in that case you could still run out of space, so this change would be helpful in that situation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants