Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] When Metamask extension is not installed, "Log in with Ethereum" button throws an uncaught exception in the console #10

Open
3 tasks
blei-schmetterling opened this issue May 25, 2024 · 1 comment

Comments

@blei-schmetterling
Copy link

Not sure why exactly it cannot fetch ETH accounts, but it doesn't fall gracefully: the button appear dead.

Here's what happens in the console:
image

And here's the JS file it complains about:
image

Steps to reproduce:

@blei-schmetterling blei-schmetterling changed the title [Bug] Log in with Ethereum button silently stops working and throws an uncaught exception in the console [Bug] When Metamask extension is not installed, "Log in with Ethereum" button throws an uncaught exception in the console May 25, 2024
@blei-schmetterling
Copy link
Author

To bypass the issue you need to install https://metamask.io, this part is obvious. The problem is to correctly handle the case when the extension is not there: I'd probably redirect to metamask webpage in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant