Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention number of EIP drafts that were submitted but not merged in EIPs Insight #115

Closed
Pandapip1 opened this issue Mar 14, 2022 · 5 comments

Comments

@Pandapip1
Copy link
Contributor

https://hackmd.io/@poojaranjan/EthereumImprovementProposalsInsight mentions the number of merged drafts, but not the number of PRs submitted that add new EIP files and the number of draft EIPs waiting to be merged. It would also be nice to have a breakdown of the category (ERC, core, etc...) of the drafts that were merged, and the drafts that are currently pending approval.

@poojaranjan
Copy link
Member

Good suggestions, thanks!

@poojaranjan
Copy link
Member

@Pandapip1 thanks for sharing improvement suggestions.

nice to have a breakdown of the category (ERC, core, etc...) of the drafts that were merged

I will have it added for the month of March and onward

drafts that are currently pending approval

Do you seem to have any specific thought in mind as why people will be interested in data for open PR with an improvement proposal before merge as "Draft"?

I can't seem to find a good reason to have this data included unless they are useful to a certain set of people. Because not all of them end up merged and unless merged there is no need for community review and/or feedback.

Happy to add to the next EIPIP meeting to collect more thoughts on this.

@Pandapip1
Copy link
Contributor Author

I can't seem to find a good reason to have this data included

It would be nice to compare the number of PRs opened in a specific track to the number that are being merged for that track. Notably, it could signal a problem if the former is much larger than the latter.

@poojaranjan
Copy link
Member

The EIPs Insight for March 2022 has additional information as requested.
Thanks for the suggestion, @Pandapip1, we hope to continue sharing.

@poojaranjan
Copy link
Member

Feel free to close the issue if you think it has been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants