Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for Input: Change Solidity in Final ERC-7201 #327

Closed
SamWilsn opened this issue Mar 13, 2024 · 4 comments
Closed

Call for Input: Change Solidity in Final ERC-7201 #327

SamWilsn opened this issue Mar 13, 2024 · 4 comments

Comments

@SamWilsn
Copy link
Collaborator

Call for Input

Decision

Do we merge ethereum/ERCs#201 ?

If Affirmed

ERC-7201's specification section is modified.

If Rejected No change.
Method Rough Consensus
Deadline April 12th, 2024

Background

Changing:

- keccak256(abi.encode(uint256(keccak256(id)) - 1)) & ~bytes32(uint256(0xff))
+ keccak256(abi.encode(uint256(keccak256(bytes(id))) - 1)) & ~bytes32(uint256(0xff))
@SamWilsn
Copy link
Collaborator Author

I am in favour of merging this pull request. It seems to correct an error in the original document without changing its meaning.

@abcoathup
Copy link

I support merging (I don't have a vote).
Whilst I am generally against modifying final EIPs, this is a correction that is approved by one of the authors. Though we need a standard process for agreeing corrections.

@poojaranjan poojaranjan mentioned this issue Mar 27, 2024
16 tasks
@g11tech
Copy link

g11tech commented Apr 10, 2024

in favor of fixing typos, so yes to proposal

@poojaranjan poojaranjan mentioned this issue Apr 11, 2024
19 tasks
@SamWilsn
Copy link
Collaborator Author

The consensus on this issue seems to be merging, so merge I shall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants