Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call For Input: Should we entertain the typo correction PRs #332

Closed
g11tech opened this issue Apr 8, 2024 · 4 comments
Closed

Call For Input: Should we entertain the typo correction PRs #332

g11tech opened this issue Apr 8, 2024 · 4 comments

Comments

@g11tech
Copy link

g11tech commented Apr 8, 2024

Call for Input

Decision

Should we merge the typo correction PRs which might just be people farming via contributions

If Affirmed

we merge such PRs

If Rejected such PRs will be closed
Method Rough Consensus
Deadline May 8 2024

Context

Such kind of PRs ethereum/EIPs#8254

may be we should add a spell checker in the first place?

@g11tech
Copy link
Author

g11tech commented Apr 8, 2024

I am against entertaining such PRs and closing them off

@poojaranjan poojaranjan mentioned this issue Apr 10, 2024
16 tasks
@xinbenlv
Copy link

No strong preference, fine either way

@SamWilsn
Copy link
Collaborator

SamWilsn commented Apr 10, 2024

I am in favour of merging pull requests fixing typos. I don't even think they need a call for input, as long as an editor has checked the diff.


may be we should add a spell checker in the first place?

Theoretically we have one. Not sure why it isn't working.

@poojaranjan poojaranjan mentioned this issue Apr 11, 2024
19 tasks
@poojaranjan poojaranjan changed the title Call For Input: hould we entertain the typo correction PRs Call For Input: Should we entertain the typo correction PRs Apr 16, 2024
@poojaranjan poojaranjan mentioned this issue Apr 25, 2024
14 tasks
@SamWilsn
Copy link
Collaborator

Doesn't seem to be a strong consensus either way. I'm going to close this for now, but can reopen if we need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants