Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem rendering some "embarcadero samples" icons #51

Closed
carloBarazzetta opened this issue Aug 21, 2020 · 10 comments
Closed

Problem rendering some "embarcadero samples" icons #51

carloBarazzetta opened this issue Aug 21, 2020 · 10 comments

Comments

@carloBarazzetta
Copy link
Contributor

In past, all the icons present into folder "D:\ETHEA\GitHub_EtheaDev\SVGIconImageList\Demo\NewSydneyVectors" where rendered correctly.
Now RAD_SERVER_Product icon.svg and C++Builder project icon.svg is not rendered correctly.
I remember that I've fixed a problem of initialitazion of svg color from black to inherit... but I'm not sure...
@pyscripter , can you check this problem?

@carloBarazzetta
Copy link
Contributor Author

for example, I remember that "C++Builder project icon.svg" problem was the definition of st2 style, as display none and stroke black.
the "circle" with st2 was rendered black, but it shouldn't be rendered because the style is display none.
Now I'm searching the bug reintroduced probably with some merge...

@pyscripter
Copy link
Collaborator

I will have a look.

@pyscripter
Copy link
Collaborator

Here is how it is shown here. It shows the same in the browser.

image

@pyscripter
Copy link
Collaborator

And here are all the product icons:

image

@carloBarazzetta
Copy link
Contributor Author

And here are all the product icons:

image

Notice the problem into icon 285 and 290.
For 285 I've found the problem: an SVG with Display false is rendered, so with this fix the "black circle" is not rendered:
if (FPath = nil) or (FDisplay = tbFalse) {or (FPath.GetLastStatus <> OK)} then (line 962 of SVG.pas)

@carloBarazzetta
Copy link
Contributor Author

carloBarazzetta commented Aug 21, 2020

For RAD_SERVER_Product icon.svg the problem is more complex:
for example the section:
<g id="Camada_3" class="st3">
<g>
<path class="st4" d="M1069.58,1964.76c0,0-184.86,1236.13,1199.79,1512.77c319.84,63.9,1472.02,279.11,1472.02,279.11"/>
</g>
</g>
produce a blue line, because class st4 define the stroke as blue.
But the class st3 used into "id" node define display:none;
Any idea how to fix it?

@pyscripter
Copy link
Collaborator

I will submit a PR for this.

@pyscripter
Copy link
Collaborator

Please check with the latest PR.

@pyscripter
Copy link
Collaborator

Is it OK now?

@carloBarazzetta
Copy link
Contributor Author

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants