Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please document how this plugin relates to ep_authornames #24

Closed
rhansen opened this issue Sep 3, 2020 · 1 comment
Closed

Please document how this plugin relates to ep_authornames #24

rhansen opened this issue Sep 3, 2020 · 1 comment

Comments

@rhansen
Copy link
Member

rhansen commented Sep 3, 2020

https://www.npmjs.com/package/ep_authornames looks similar to this plugin. How do they relate/differ? The README for this plugin has a "Why did I rewrite this?" section. Is this plugin a rewrite of ep_authornames? Please document in the README.

@JohnMcLear
Copy link
Member

ep_authornames modifies the actual DOM after edit. So basically it writes a title to each span, which is fine, but if you are processing the DOM it looks like an edit event.

ep_author_hover works different to ep_authornames in that it writes the "author name" in an element that is in outerdocbody IE it never modifies innerdocbody so never triggers an "edit" event.

I'm not sure this needs to be in the README but it's here for posterity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants