Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment popup is not displayed correctly on some mobile devices #192

Open
tim-krieger opened this issue Mar 8, 2021 · 4 comments
Open

Comments

@tim-krieger
Copy link

Popup on my iPad (2019), Safari mobile, recent version of ep_comments_page, etherpad 1.8.12:

image

@JohnMcLear
Copy link
Member

@seballot any idea how this can happen?

@seballot
Copy link
Contributor

seballot commented Mar 9, 2021

Yep : https://github.com/ether/ep_comments_page/blob/master/static/js/newComment.js#L85

The popup is aligned with comment icon, which does not work when comment icon is closed to the right border of the screen. Should be easy fix

@tim-krieger
Copy link
Author

I think my iPad is not recognized as media only screen (800px). In web inspector the popup is displayed correctly. Should this be fixed in ether/etherpad-lite? It also infects other plugins with toolbar popups like ep_embedded_hyperlinks2.
image

@tim-krieger
Copy link
Author

If I use max-width 992px instead of 800px in popup.css (etherpad-lite) the new comment popup is diplayed correctly (iPad 2020).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants