Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untranslatable, hardcoded english strings in code #1263

Closed
marcelklehr opened this issue Dec 5, 2012 · 11 comments
Closed

Untranslatable, hardcoded english strings in code #1263

marcelklehr opened this issue Dec 5, 2012 · 11 comments

Comments

@marcelklehr
Copy link
Contributor

The following strings aren't marked for translation, hence they don't exist in a translation template:

  1. Please enter a name (occurs when one tries to create a pad without a name)
  2. Enter your name (Shown in "user view" when user hasn't set name)
  3. 1 unnamed author (Shown in timeslider when user hasn't set name)
  4. Clear authorship colors on entire document? (In a confirmation window after pressing "Remove author colours" button)
  5. Import now (Button text in Import/Export view)
  6. This revision is now marked as a saved revision (Shown when user presses "Star" button)
  7. Import is not available. To enable import please install abiword (Shown in Import/Export view if admin hasn't installed the needed components)

This list was taken from https://translatewiki.net/wiki/Thread:Translating_talk:Etherpad_lite/Strings_not_marked_for_translation

@joker-x
Copy link
Contributor

joker-x commented Dec 6, 2012

if you are busy, i could try to solve this issue

@marcelklehr
Copy link
Contributor Author

yea, feel free!

@joker-x
Copy link
Contributor

joker-x commented Dec 7, 2012

Now, i'm working on loading translation ini files (if any) of any plugin under its locales folder and merge with ini files of the core. This will allow developers build multilingual plugins and even create alternative translation as plugin.

Good idea?

@marcelklehr
Copy link
Contributor Author

Possibly, but I would recommend you wait until l10n is stable (i intend
to make some changes to the current system) -- in the meantime you could
work on this issue if you want...

@joker-x
Copy link
Contributor

joker-x commented Dec 7, 2012

Are we keep ini format of language files? this point is the only that can affect to this future feature...

I hope that i will find job soon and then i will have less time for etherpad and other fancy free software, so i will try to take advantage of the free time, while it is useful :D

@joker-x
Copy link
Contributor

joker-x commented Dec 9, 2012

I got it! I will wait for merging #1274 before do another pull request :D

@marcelklehr
Copy link
Contributor Author

Could you also fix this too while you are at it?
https://translatewiki.net/wiki/Thread:Support/About_EtherpadLite:Pad.importExport.successful/en

thanks

@joker-x
Copy link
Contributor

joker-x commented Dec 9, 2012

The problem is the message don't show?

@marcelklehr
Copy link
Contributor Author

The problem is that the same message key is used for both successful
import and successful export. @siebrand advises us to split them

@joker-x
Copy link
Contributor

joker-x commented Dec 9, 2012

Ready joker-x@ff8b4b6

@marcelklehr
Copy link
Contributor Author

pulled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants