Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Express is stuck at 3.1.0 #1738

Closed
JohnMcLear opened this issue Apr 15, 2013 · 9 comments
Closed

Express is stuck at 3.1.0 #1738

JohnMcLear opened this issue Apr 15, 2013 · 9 comments
Assignees
@JohnMcLear
Labels
Minor Bug

Comments

@JohnMcLear
Copy link
Member

3.1.1 is also fine
@JohnMcLear
Copy link
Member Author

checking out 3.1.2 then doing npm update shows error. will bisect

@JohnMcLear
Copy link
Member Author

Caused by expressjs/express@4bb91b3

@JohnMcLear
Copy link
Member Author

Caused by senchalabs/connect@3f166cc

@JohnMcLear
Copy link
Member Author

Caused by tj/node-cookie-signature@fd9b451#commitcomment-3015126

JohnMcLear referenced this issue in tj/node-cookie-signature Apr 15, 2013
Changed underlying HMAC algo. to sha512.
fd9b451
@JohnMcLear JohnMcLear mentioned this issue Apr 15, 2013
Closed
@JohnMcLear JohnMcLear reopened this Apr 15, 2013
@JohnMcLear JohnMcLear added the Bug label Nov 1, 2014
@JohnMcLear JohnMcLear self-assigned this Nov 1, 2014
@JohnMcLear
Copy link
Member Author

https://github.com/strongloop/express/wiki/Migrating-from-3.x-to-4.x

The amount of things we would need to rewrite to migrate to 4 is rediculous, just not worth the energy right now.

@JohnMcLear
Copy link
Member Author

#2296

@JohnMcLear JohnMcLear mentioned this issue Jan 19, 2015
Closed
7 tasks
@devoidfury
Copy link
Contributor

Started on this here: devoidfury/etherpad-lite/tree/express4. The etherpad-yajsml exported static server isn't compatible, so we'll need to either wrap it or update it.

Edit: never mind, that's not an issue. Going through the rest; backend tests passing.

The minify/cache middleware seems to be junking the font files, everything else looks like it's working.

@JohnMcLear
Copy link
Member Author

Nice @devoidfury! Amazing! So fast too... Get a pull request in? We're rewriting the minify/cache middleware this weekend so hopefully we can deal with that then!

@devoidfury devoidfury mentioned this issue Apr 9, 2015
Merged
@JohnMcLear
Copy link
Member Author

Solved thanks to @devoidfury =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnMcLear JohnMcLear

Labels
Minor Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohnMcLear @devoidfury