Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does the embed parameter showControls do? #2563

Closed
chaodoze opened this issue Mar 24, 2015 · 4 comments
Closed

What does the embed parameter showControls do? #2563

chaodoze opened this issue Mar 24, 2015 · 4 comments
Assignees
Labels

Comments

@chaodoze
Copy link

It doesn't seem to do anything for me. Thanks!

@JohnMcLear JohnMcLear added the Bug label Mar 24, 2015
@JohnMcLear JohnMcLear self-assigned this Mar 24, 2015
@JohnMcLear
Copy link
Member

Controls is the editbar. https://beta.etherpad.org/p/foo?showControls=false - it looks like it's broken ;\

@chaodoze
Copy link
Author

Thanks, John. I just figured that out by looking at the source too. It looks like $('#editbar').show() is called after the parameter arguments are processed (in line#158 static/js/pad_editbar.js).

The next line then calls hooks.callAll("postToolbarInit"...). I'm not familiar enough with the source: Is there a way to subscribe to the "postToolbarInit" event, and then call $('#editbar').hide() when that event is fired?

@JohnMcLear
Copy link
Member

I need to fix the bug, sit tight

@JohnMcLear
Copy link
Member

Bug fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants