Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid export path crashes etherpad #3050

Closed
jsimpsoncd opened this issue Sep 8, 2016 · 5 comments
Closed

Invalid export path crashes etherpad #3050

jsimpsoncd opened this issue Sep 8, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@jsimpsoncd
Copy link

Client: Chrome, various versions.
Host: Linux Mint 18, x64, based on Ubuntu 16.04 LTS npm 3.5.2 and nodejs 4.2.6
steps to reproduce
Start etherpad (I started via debugRun.sh). visit an invalid export path, example:
http://localhost:9001/p/path/pad/export/txt
what you expected to happen
An error, or a failed export.
what actually happened
etherpad crashed

@jdittrich
Copy link
Contributor

jdittrich commented Sep 28, 2016

Thanks!

I just tried it with the demo and got:

Error: remote exception: remote exception: remote exception: remote exception: remote exception: remote exception: expected headersComplete; HTTP response from sandboxed app had incomplete headers.
at Error (native)
C++ location:(remote):??
type: failed

Have not tried it locally yet.

@Gared Gared added this to the 1.6.1 milestone Dec 19, 2016
@Gared Gared added the Bug label Dec 19, 2016
@Gared Gared self-assigned this Dec 19, 2016
@Gared
Copy link
Member

Gared commented Dec 22, 2016

@jdittrich Thx for reporting this bug. If you have time please test my PR

@jdittrich
Copy link
Contributor

jdittrich commented Dec 23, 2016

@Gared With your change, I don't get a crash and I can continue to write. Minor problem: The page now continues to show the "reloading" indicator.

@Gared
Copy link
Member

Gared commented Dec 23, 2016

@jdittrich I know, but this fixes the crash. If you think we should fix this behaviour please reopen this issue

@jdittrich
Copy link
Contributor

@Gared: I think teh reload indication is a non-harmful edgecase, so I'd leave this issue closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants