Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved readibility in default font size and highlight colors #3233

Closed
joaobarcia opened this issue Jul 31, 2017 · 10 comments
Closed

Improved readibility in default font size and highlight colors #3233

joaobarcia opened this issue Jul 31, 2017 · 10 comments

Comments

@joaobarcia
Copy link

Hi all, thanks for the great project. I use etherpad with several remote teams, but one of the major issues I've faced when trying to make others adopt the tool is the initial readability.

Issue: Readability for default font settings could be improved

  • font-size is 12px
  • color palette seems to be generated by the array at src/node/db/AuthorManager.js

capture1

Proposal: Increase font size and improve highlight colors

capture2


Happy to create a PR if the community agrees with the proposal.

Cheers

@jainendra
Copy link
Contributor

I agree with this, currently etherpad doesn't have good readability

@Dhwty
Copy link

Dhwty commented Aug 4, 2017

I feel like this sort of a change should be optional -- something that can be enabled in the settings -- rather than the only choice. I say this because I work with a low-resolution screen and a dark theme, and this would be nightmarish for my ability to read my documents.

@jainendra
Copy link
Contributor

jainendra commented Aug 4, 2017

I agree with @Dhwty. @joaobarcia It will be awesome if you do something like @Dhwty mentioned and raise a PR

@joaobarcia
Copy link
Author

Great, will try to find some time to work on it the coming week.

@Dhwty , just to make sure I come up with a good proposal it would be nice to understand your user case as well. Why do you think it would impact your ability to read documents? The letters get too big in a low resolution screen? And about the dark theme, is it the theme of your os/browser, or does etherpad have themes that I didn't know of? And how would the highlights affect your readibility?

Thanks

@Dhwty
Copy link

Dhwty commented Aug 7, 2017

@joaobarcia Happy to help. I have some visual processing disabilities that make paragraphs of large text nearly illegible, and I can't handle much light, so I do all of my work in dimly-lit rooms, on dark backgrounds with moderately-sized, light text. (I realise I am such an edge case, and this is only going to affect like twenty other people in the entire world, and three of them are using my server.)

Etherpad's current base font size is a good match for my screen and me -- which I realise probably makes it too damn small to read for anyone else, but I do need an option to keep it that size. (My screen's 1152x864, if you want a good laugh.)

The 'dark theme' is actually from a plugin -- ep_themes, which IIRC doesn't work straight out of the box, but I got it going. What it unfortunately doesn't affect, though is the range of highlight colours. Which, with a dark background and light text, do need to be dark.

So, here's a screenshot of what I'm working with and trying to maintain:
2017-08-07-etherdark

The light blue highlight in the chat is a user who is not currently on the document, and therefore has had their highlight dimmed, but the dark purple is someone present.

@joaobarcia
Copy link
Author

Wow, interesting user case, @Dhwty ! Always learning :) Ok, will try to take all that info in consideration.

@HairyFotr
Copy link
Contributor

@Dhwty If you want to darken the icons as well, add this to etherpad's pad.css. I haven't checked if/how it could be added to ep_themes, and it seems some plugin icons don't have the same attribute.

#editbar [data-type="button"] {
  filter: invert(100%);
}

@Dhwty
Copy link

Dhwty commented Aug 10, 2017

@HairyFotr Neat! Thanks! I've got to go tweak a couple of things so it applies across the whole row (and not to the user colour select button, which was an amusing side effect), but where it works right off, it looks so much better.

@muzzol
Copy link

muzzol commented Sep 29, 2017

any news on this feature request?
just installed my first instance and first thing I notice is how bad the default readability is.

just an option for default size and font could do it for me.

@joaobarcia
Copy link
Author

@muzzol , not from my side. Still have it on my backlog to try to submit a PR but haven't had any spare time lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants