Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the Dockerfile here #3524

Closed
Trolldemorted opened this issue Dec 10, 2018 · 2 comments
Closed

move the Dockerfile here #3524

Trolldemorted opened this issue Dec 10, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@Trolldemorted
Copy link

At the moment your Dockerfile resides in a separate repository and clones this repo when building. Since docker uses overlayfs track container build stages this is a bad idea, could you consider moving the Dockerfile here and change the git clone command to COPY?

We would gladly drop our own custom etherpad-lite Dockerfile and help improving the official one, if we can get features like persistency and smaller image sizes into the official builds.

@fcecagno
Copy link

fcecagno commented Jan 9, 2019

Agreed, I do not quite understand why it uses supervisord, since as far as I understand, it's a node app, and that's it.

This is how we do it: https://github.com/mconftec/etherpad-lite/blob/mconf/Dockerfile
And this is our entrypoint: https://github.com/mconftec/etherpad-lite/blob/mconf/docker-entrypoint.sh
We use jq to be able to modify settings.json using environment variables.

Having the Dockerfile in the same repository enables us to enable automated builds more easily.

@muxator
Copy link
Contributor

muxator commented Jan 23, 2019

I agree. The Dockerfile has to be moved inside the main repository.

About configuring via environment variables: I have been thinking about it for some time now. Since it seems that this is a common use case, I have opened #3543.

@muxator muxator added the docker label Jan 23, 2019
@muxator muxator added this to the 1.8 milestone Mar 8, 2019
@muxator muxator closed this as completed in bf68666 Mar 8, 2019
@muxator muxator self-assigned this Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants