Misuse of "Import" erases all history data #5213

jej · 2021-10-01T20:27:59Z

Describe the bug
I see some closed issues about this, but maybe it worths to reopen it.
I suggested to a friend to use etherpad for a collaboration work. After few days and many modifications, she wanted to import an inline image in the text. She clicked on "Import/Export", picked an image file and didn't care about the warning... Of course the pad was scrambled by a binary text, and the image was not inserted inline as expected by the user. The problem is that now the historic does not show the revisions any more. The revisions are browsable with the slider, but current content only is displayed. All previous revisions seems recorded as usual, but not available.
I tested this on https://framapad.org/fr/ . I don't know what version of etherpad they use.

To Reproduce
Steps to reproduce the behavior:

Write/modify some text, in order to create some revisions.
Click on 'Import/Export'.
Pickup a binary image file (ex. png/jpg)
Import it, acknowledge the warning.
The binary data replace the text. Eventually: erase it and add some text.
Look at the history to see if previous revisions are still displayed.

Expected behavior
It's not a problem if binary data erase the current version, but at least it should be possible to retrieve the previous content of the pad.
Maybe the GUI should be more careful with import. A mandatory checkbox could make the user aware that all the content will be replaced, instead of a simple button.

Server (please complete the following information):

Etherpad version: ?
Here: https://framapad.org/

JohnMcLear · 2021-10-02T09:31:06Z

There is a plugin for forking pads to a new state from a point in time. ep_fork maybe? You access the previous revision through the timeslider. Plugins are visible on the plugin list page.
Re importing ux, I would say the expected ux for import in any text editor is to replace the whole document no?

jej · 2021-10-02T09:38:04Z

Thanks for your reply.

I didn't know this plugin. I will test for my own use.
The problem here is the bug about the timeslider. If the import replace the doc, why the slider allows to browse the revisions but don't show them? I would say that import a doc just create a new revision with the new content. But here the concept of the pad is broken...

JohnMcLear · 2021-10-02T09:41:33Z

Gimme 5 mins will find it for you.
Import should create a new revision, you are right! Can you provide exact steps to replicate then here because if you are saying it's not creating a new revision something is very broken! Please provide steps to replicate on a clean install / no plugins etc.

JohnMcLear · 2021-10-02T09:44:04Z

https://www.npmjs.com/package/ep_copypad -- give this a try, I'm not sure why it's not visible in npm / plugin list tho! You would need to install via npm install ep_copypad though as it isn't visible in the plugin list for some reason..

jej · 2021-10-02T09:45:00Z

To Reproduce
Steps to reproduce the behavior:

Write/modify some text, in order to create some revisions.
Click on 'Import/Export'.
Pickup a binary image file (ex. png/jpg)
Import it, acknowledge the warning.
The binary data replace the text. Eventually: erase it and add some text.
Look at the history to see if previous revisions are still displayed.

JohnMcLear · 2021-10-02T09:45:07Z

RE replicating btw, I tried to replicate locally but I get an error Import failed: The upload failed, please try again

I get warning [2021-10-02 10:47:01.610] [WARN] ImportHandler - Attempt to import non-ASCII file

My assumption here is you have an instance with a modified settings.json and something like abiword or soffice enabled?

JohnMcLear · 2021-10-02T09:45:39Z

Please provide STR in a clean environment of Etherpad, not a modified one.

jej · 2021-10-02T09:48:07Z

Yeah that's the problem, I don't manage the platform Framapad. I guess it's not so modified. My own version is full of plugins...
Do you know a clean fresh install I can try?

JohnMcLear · 2021-10-02T09:51:25Z

You can spin one up using the docs really quickly/easily, that's probably the best approach to ensure it's clean and we can replicate?

JohnMcLear · 2021-10-02T10:01:29Z

Just a thought. Image size could be maxing out buffer causing timeslider to not work? An idea, not researched

jej · 2021-10-02T10:06:13Z

Ok... I can reproduce with a clean install :

Write/modify some text, in order to create some revisions.
Click on 'Import/Export'.
Pickup a HTML file.
Import it, acknowledge the warning.
The HTML content replace the text. (Eventually: erase it and add some text.)
Look at the history to see if previous revisions are still displayed.

In my case, the slider can browse the revisions but nothing is displayed. If I CTRL+SHIFT+R the page, the current content is displayed for any revisions.

JohnMcLear · 2021-10-02T10:20:12Z

ack, gimme 5 will check

JohnMcLear · 2021-10-02T10:21:34Z

I see previous revisions so unable to replicate. Do you get any errors in console?

JohnMcLear · 2021-10-02T10:24:41Z

What size is the HTML file contents?

I was able to get curSplice[sline] not populated, actual curSplice contents is Array(3) [ 0, 2, undefined ] . Possibly related to https://github.com/ether/etherpad-lite/issues/2802

I think STR for that is insert content, import empty HTML file, type some stuff, visit timeslider, click play.

JohnMcLear · 2021-10-02T10:27:55Z

I think the bug here is #5214 - I made a new issue as to remove the noise. Please can you confirm that in your developer console you see the same error as above?

jej · 2021-10-02T10:44:10Z

The HTML file is 18ko.
If I debugRun.sh it works as expected. But if I run.sh I get the bug.
I don't see any error.

[2021-10-02 12:34:32.900] [INFO] access - [CREATE] pad:testpad socket:6VP8nWdfr5ZxrCu0AAAD IP:127.0.0.1 authorID:a.m0Om9fc1qS3Fgmur
[2021-10-02 12:35:57.571] [WARN] console - Ignoring unsupported elements (you might want to install a plugin): header, h1, a, nav, aside, article, table, tbody, tr, th, td, img, section, h2, footer, address
[2021-10-02 12:36:01.854] [INFO] access - [LEAVE] pad:testpad socket:6VP8nWdfr5ZxrCu0AAAD IP:127.0.0.1 authorID:a.m0Om9fc1qS3Fgmur
[2021-10-02 12:36:02.888] [INFO] access - [ENTER] pad:testpad socket:4_26Ns5UNNFp4Y5BAAAE IP:127.0.0.1 authorID:a.m0Om9fc1qS3Fgmur

Maybe something related to browser's cache...

JohnMcLear · 2021-10-02T10:58:21Z

Gimme 5 will test with run.sh

JohnMcLear · 2021-10-02T11:05:35Z

I can still access old revisions(it works fine other than errors in console) when using run.sh but do experience the error in #5214 which I wonder if we publish a fix for that might fix your issue? Either way Etherpad is designed to never lose document fidelity, history or integrity, it's kind of a big thing 📦

Can you clear the browser cache and test between run.sh and debugRun.sh

jej · 2021-10-02T11:11:12Z

Ok, I cleared. But I didn't think to look at JS console log, sorry...

When I move the revisions slider I get this for each move:

Uncaught TypeError: $(...)[0] is undefined
    a http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/timeslider.js?callback=require.define&v=a7da73b0:70
    a http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/timeslider.js?callback=require.define&v=a7da73b0:70
    u http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/timeslider.js?callback=require.define&v=a7da73b0:70
    loadBroadcastJS http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/timeslider.js?callback=require.define&v=a7da73b0:70
    n http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/timeslider.js?callback=require.define&v=a7da73b0:73
    h http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/timeslider.js?callback=require.define&v=a7da73b0:73
    loadBroadcastSliderJS http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/timeslider.js?callback=require.define&v=a7da73b0:73
    dispatch http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    handle http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    add http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    we http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    each http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:27
    each http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:27
    we http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    on http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    t http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    loadBroadcastSliderJS http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/timeslider.js?callback=require.define&v=a7da73b0:73
    dispatch http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    handle http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    add http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    we http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    each http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:27
    each http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:27
    we http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    on http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    t http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=a7da73b0:38
    loadBroadcastSliderJS http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/timeslider.js?callback=require.define&v=a7da73b0:73
    handleClientVars http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/timeslider.js?callback=require.define&v=a7da73b0:3
    init http://0.0.0.0:9001/javascripts/lib/ep_etherpad-lite/static/js/timeslider.js?callback=require.define&v=a7da73b0:3
    emit http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:6
    onevent http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:8
    onpacket http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:8
    exports http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:8
    emit http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:6
    ondecoded http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:6
    exports http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:8
    emit http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:6
    add http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:6
    ondata http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:6
    exports http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:8
    emit http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:6
    onPacket http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:6
    setTransport http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:6
    emit http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:6
    onPacket http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:7
    n http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:7
    decodePayload http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:7
    onData http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:7
    doPoll http://0.0.0.0:9001/socket.io/socket.io.js?v=a7da73b0:7
timeslider.js:70:2365

JohnMcLear · 2021-10-02T11:14:45Z

Ahhhh, I bet you see a different error because of minify, let me confirm that.

And just to be 100% sure, you have no plugins installed, correct?

jej · 2021-10-02T11:16:59Z

I just followed the quick install from the git. No plugin, no setttings tweaks, just the basic install.

JohnMcLear · 2021-10-02T11:17:25Z

Hrm, nope, with minify true I still get the curSplice error.

Either way we're firing an error after this edit event, so let's get that resolved first then you can git pull and see if it's fixed?

JohnMcLear · 2021-10-02T11:18:46Z

https://discord.gg/CWQXkG7K for Discord btw

jej · 2021-10-02T11:19:28Z

Ok perfect. I keep my install for the following investigations!
Thanks for your support.

JohnMcLear · 2021-10-02T14:05:55Z

After some more play I got the error Uncaught TypeError: $(...)[0] is undefined.

I deleted all pad contents, did an import of a .html file (which imported blank) and now I get the error. I assume it's related to line numbers.

rhansen · 2021-10-29T06:39:21Z

This should be fixed by PR #5250.

webzwo0i · 2021-10-29T09:36:13Z

Unfortunately, there are probably two bugs. The "Uncaught TypeError" should be fixed by #5250.
The curSplice problem is a duplicate of #5214 and should be fixed when #2911 is ready

JohnMcLear mentioned this issue Oct 2, 2021

This .etherpad contents breaks timeslider playback #5214

Open

JohnMcLear self-assigned this Oct 2, 2021

JohnMcLear mentioned this issue Oct 2, 2021

Timeslider bugfixes for empty pad contents #5215

Closed

2 tasks

webzwo0i mentioned this issue Oct 28, 2021

timeslider scrollTo: fixes wrong line number calculation #5250

Merged

rhansen linked a pull request Oct 29, 2021 that will close this issue

timeslider scrollTo: fixes wrong line number calculation #5250

Merged

rhansen closed this as completed Oct 29, 2021

webzwo0i mentioned this issue Oct 29, 2021

Fix textLinesMutator when dealing with insertions/deletions at the end of pad #5253

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Misuse of "Import" erases all history data #5213

Misuse of "Import" erases all history data #5213

jej commented Oct 1, 2021 •

edited

JohnMcLear commented Oct 2, 2021

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021 •

edited

JohnMcLear commented Oct 2, 2021

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021 •

edited

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021 •

edited

jej commented Oct 2, 2021 •

edited

JohnMcLear commented Oct 2, 2021

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

rhansen commented Oct 29, 2021

webzwo0i commented Oct 29, 2021

Misuse of "Import" erases all history data #5213

Misuse of "Import" erases all history data #5213

Comments

jej commented Oct 1, 2021 • edited

JohnMcLear commented Oct 2, 2021

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021 • edited

JohnMcLear commented Oct 2, 2021

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021 • edited

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021 • edited

jej commented Oct 2, 2021 • edited

JohnMcLear commented Oct 2, 2021

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

jej commented Oct 2, 2021

JohnMcLear commented Oct 2, 2021

rhansen commented Oct 29, 2021

webzwo0i commented Oct 29, 2021

jej commented Oct 1, 2021 •

edited

JohnMcLear commented Oct 2, 2021 •

edited

JohnMcLear commented Oct 2, 2021 •

edited

JohnMcLear commented Oct 2, 2021 •

edited

jej commented Oct 2, 2021 •

edited