Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check on Default Social Image asset url #131

Closed
alexjcollins opened this issue Sep 6, 2018 · 0 comments
Closed

Check on Default Social Image asset url #131

alexjcollins opened this issue Sep 6, 2018 · 0 comments
Assignees
Labels

Comments

@alexjcollins
Copy link
Member

Description

The recent update to SEO 3.3.1 (Craft Pro 3.0.23.1) took out/crashed the front-end of one our Craft sites. Together with the guys at Craft we identified this being due to a bug in the SEO plugin (related to the ‘Default Social Image’):

Asset volumes have a setting which determines whether or not they are supposed to have public URLs. If you try to access a URL of an asset uploaded to such a volume, it will return an URL, which is a likely scenario here.

The plugin does not check whether the URL for an asset is a string or null (even though the docblock documents this behavior, https://github.com/craftcms/cms/blob/develop/src/elements/Asset.php#L706), before passing it on to a method which requires string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants