Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear how to transfer ETH from L1 to L2 using bridge #85

Closed
platocrat opened this issue Apr 24, 2021 · 0 comments
Closed

Unclear how to transfer ETH from L1 to L2 using bridge #85

platocrat opened this issue Apr 24, 2021 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@platocrat
Copy link
Contributor

platocrat commented Apr 24, 2021

Description
The docs don't make it clear how a user should transfer ETH from L1 to L2 using bridge contracts.
Here are some paraphrased issues surfaced by @funfair-tech and discussion with @snario:

  • Not clear whether we should use transfer or the deposit method to get ETH to L2. When do you use which method?
  • We should have integration tests around sending WETH from one L2 address to another

Motivation

  • From our docs, it should be clear when to use deposit, transfer, or transferFrom on L1 and L2.
  • Each method should ideally have its own outlined "flow" for users and developers to understand the higher-level process of each.

Estimated effort and complexity

  • Effort: 1-2
  • Complexity: 0

Tags to related packages

  • contracts
@snario snario added the documentation Improvements or additions to documentation label Apr 24, 2021
@platocrat platocrat added the bug Something isn't working label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants