This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Add opnode makefile, lints, and go1.18 #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily for easier building and linting.
trianglesphere
force-pushed
the
jg/add_makefile
branch
from
4a6821e
to
556d8d5
Compare
The misspell linter was trying to correct `strat` to `start`. This is typically correct, but not in this instance.
This enables the nice test ouput with `go test -v` that lists each test without polluting the output with logs from passing tests.
trianglesphere
force-pushed
the
jg/add_makefile
branch
from
556d8d5
to
c9c1e0a
Compare
Required for go version 1.18
trianglesphere
changed the title
protolambda
suggested changes
Mar 22, 2022
trianglesphere
force-pushed
the
jg/add_makefile
branch
from
e7e32ed
to
8ac860e
Compare
Codecov Report
@@ Coverage Diff @@
## main #272 +/- ##
==========================================
- Coverage 55.32% 55.20% -0.12%
==========================================
Files 39 39
Lines 2856 2862 +6
==========================================
Hits 1580 1580
- Misses 1117 1121 +4
- Partials 159 161 +2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This does the following:
misspelllint to the makefiles, docs, and CINotes
The misspell lint is good, but not perfect. The only false positive that I found was it was trying to correct
strattostart.Metadata