Skip to content
This repository has been archived by the owner on Apr 11, 2021. It is now read-only.

Importing @eth-optimism/plugins/hardhat/ethers breaks source map support #29

Closed
krzkaczor opened this issue Mar 21, 2021 · 3 comments
Closed

Comments

@krzkaczor
Copy link

krzkaczor commented Mar 21, 2021

Describe the bug
import '@eth-optimism/plugins/hardhat/ethers'
breaks source map supports (line numbers are off).

This is because importing ganache-core which imports source-map-support/register.

A related issue in hardhat/waffle: TrueFiEng/Waffle#281

Quick workaround: (for end-users of this lib)
source-map-support is able to ąvoid re-registering if one particular version is registered multiple times so a reasonable workaround is to force install only one particular version. To do this add in package.json:

"resolutions": {
    "source-map-support": "0.5.19"
  }

Solution:

  1. Help me with: Fix sourcemap support once and for all trufflesuite/ganache#879
@smartcontracts
Copy link
Contributor

Glad that trufflesuite/ganache#879 seems to be getting resolved. We're likely going to remove all ethereumjs-vm functionality from this repository and prefer using geth directly, which should fix the issue if not immediately fixed in ganache-core.

@gakonst
Copy link

gakonst commented Mar 24, 2021

This is the PR which removes ethereumjs-vm: #31

@smartcontracts
Copy link
Contributor

Closing this since we no longer use ethereumjs-vm under the hood (at least for now). Let me know if you need any other help!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants